[ 
https://issues.apache.org/jira/browse/CASSANDRA-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026179#comment-14026179
 ] 

Sylvain Lebresne commented on CASSANDRA-7366:
---------------------------------------------

The one downside I see might be that, unless I'm wrong, this will roughly 
double the size of the counters for all existing ones and I wonder if the code 
saved is worth that disagreement for our users.

I'm slightly ambivalent here on what is the best choice. On the one side if we 
ever do this, better do it sooner than later. On the other side, we've already 
made many chances to counters, so keeping a small amount of code to save some 
trouble to upgrades feels nicer.

Anyway, not feeling extremely strongly here though slightly leaning towards 
keeping things as they are to be nice to upgraders if I'd have to pick. But 
with that caveat, +1 on the patch technically speaking.

> Use node's hostId instead of generating counterId-s
> ---------------------------------------------------
>
>                 Key: CASSANDRA-7366
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7366
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> Now that we no longer renew, or have to renew, counter ids - we can/should 
> simply reuse the node's hostId.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to