[
https://issues.apache.org/jira/browse/CASSANDRA-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027899#comment-14027899
]
Aleksey Yeschenko commented on CASSANDRA-7366:
----------------------------------------------
Well, to me the point of the patch is not to get rid of some code, but to
further simplify the implementation conceptually and kill one more concept
before we hit 2.1 (counter ids in this case). (kill off remote/local shards
before 3.0, kill off contexts, logical timestamps (in favor of micros) and
CounterCell entirely in 3.0 - CASSANDRA-6506).
In fact, we could kill more code (CounterId the class, etc.), but I explicitly
went with the minimal amount of change now, b/c 2.1 is so close. Just enough to
remove the concept itself (we'll get rid of the rest in 3.0).
bq. The one downside I see might be that, unless I'm wrong, this will roughly
double the size of the counters for all existing ones
Not really. Only doubling, and only the value (the context) for existing
counters in clusters that have never renewed a counter id or made a topology
change before. One benefit is that it would allows us to go the
collectTimeOrderedData() path for looking up the value of the local shard,
which would help us with the read-before-write path, which should be a
reasonable win. Saving it for another ticket though.
> Use node's hostId instead of generating counterId-s
> ---------------------------------------------------
>
> Key: CASSANDRA-7366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7366
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 2.1.0
>
>
> Now that we no longer renew, or have to renew, counter ids - we can/should
> simply reuse the node's hostId.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
