[
https://issues.apache.org/jira/browse/CASSANDRA-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027973#comment-14027973
]
Sylvain Lebresne commented on CASSANDRA-7366:
---------------------------------------------
bq. Only doubling, and only the value (the context) for existing counters in
clusters that have never renewed a counter id or made a topology change before.
Do you mean by that that if you've already renewed counter ids then you don't
double the size of the counter context but only add some percentage of it? If
so, I agree, but I was just saying, if you've never renewed any counter id,
then each counter context will double. If you have renewed, we won't double
per-se, but we'll still grow those context the same way.
Overall, I'm not saying we shouldn't do that, I'm just listing the downside so
we're aware of what we do. And on the plus side, while we can indeed get rid of
the full CounterId code/concept, it's really just a UUID, so conceptually, I'm
not sure that we'd win that much by removing it. But don't get me wrong,
removing this would please my OCD, but since this has a small downside for
upgrader, I'm trying to convince myself that the pros outweight the cons, and
I'm not 100% convinced one way or another. But if you feel strongly, happy to
go ahead.
bq. One benefit is that it would allows us to go the collectTimeOrderedData()
path for looking up the value of the local shard
How does using the hostId makes that easier?
> Use node's hostId instead of generating counterId-s
> ---------------------------------------------------
>
> Key: CASSANDRA-7366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7366
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 2.1.0
>
>
> Now that we no longer renew, or have to renew, counter ids - we can/should
> simply reuse the node's hostId.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
