wenchaozhang-123 commented on code in PR #709:
URL: https://github.com/apache/cloudberry/pull/709#discussion_r1841764187
##########
src/backend/commands/tag.c:
##########
@@ -504,7 +504,7 @@ AddTagDescriptions(List *tags,
}
}
- if (value_cell || isnull)
+ if (isnull)
Review Comment:
Is't not right here, as when value_cell is not null, we can also enter below
logic which isnull is false. Change the line 473 to ListCell *value_cell =
NULL; is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
