wenchaozhang-123 commented on code in PR #709:
URL: https://github.com/apache/cloudberry/pull/709#discussion_r1846073455
##########
src/backend/commands/tag.c:
##########
@@ -504,7 +504,7 @@ AddTagDescriptions(List *tags,
}
}
- if (value_cell || isnull)
+ if (isnull)
Review Comment:
No, not really. We will enter below logic in two cases, value_cell is not
null or isnull is true. When value_cell is not null, isnull will be false, as a
result, we can not use `if (isnull)` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
