avamingli commented on code in PR #778: URL: https://github.com/apache/cloudberry/pull/778#discussion_r1884259830
########## src/test/regress/expected/dynamic_table.out: ########## @@ -156,24 +156,24 @@ SELECT * FROM t1 WHERE a = 2; (2 rows) -- test DROP DYNAMIC TABLE -SELECT schedule, command FROM pg_task WHERE jobname LIKE 'gp_dynamic_table_refresh%' AND command LIKE '%dt0'; - schedule | command ------------+------------------------------------------------ - 5 * * * * | REFRESH DYNAMIC TABLE dynamic_table_schema.dt0 +SELECT schedule, command FROM pg_task WHERE jobname LIKE 'gp_dynamic_table_refresh%' AND command LIKE '%dt0%'; Review Comment: Thank you for the suggested test case. I'm okay with that. However, I would like to clarify that there are already cases tested the REFRESH commands in existing cases, and the pg_task executes the same command. If there were any issues with pg_task not executing the command as expected, it would indicate a bug within pg_task, not with the dynamic table functionality itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
