avamingli commented on code in PR #778:
URL: https://github.com/apache/cloudberry/pull/778#discussion_r1886068008
##########
src/backend/commands/createas.c:
##########
@@ -1846,7 +1846,7 @@ create_dynamic_table_auto_refresh_task(ParseState
*pstate, Relation DynamicTable
dtname =
quote_qualified_identifier(get_namespace_name(RelationGetNamespace(DynamicTableRel)),
RelationGetRelationName(DynamicTableRel));
resetStringInfo(&buf);
- appendStringInfo(&buf, "REFRESH DYNAMIC TABLE %s", dtname);
+ appendStringInfo(&buf, "REFRESH DYNAMIC TABLE %s CONCURRENTLY", dtname);
Review Comment:
Yes, normal materialized views do support the CONCURRENTLY option. According
to the [PostgreSQL
docs](https://www.postgresql.org/docs/14/sql-refreshmaterializedview.html):
> CONCURRENTLY allows the materialized view to be refreshed without locking
out concurrent selects. While a standard refresh might block other connections
reading from the view, using CONCURRENTLY can be faster, especially when a
small number of rows are affected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
