avamingli commented on code in PR #778:
URL: https://github.com/apache/cloudberry/pull/778#discussion_r1886106388
##########
src/backend/commands/createas.c:
##########
@@ -1846,7 +1846,7 @@ create_dynamic_table_auto_refresh_task(ParseState
*pstate, Relation DynamicTable
dtname =
quote_qualified_identifier(get_namespace_name(RelationGetNamespace(DynamicTableRel)),
RelationGetRelationName(DynamicTableRel));
resetStringInfo(&buf);
- appendStringInfo(&buf, "REFRESH DYNAMIC TABLE %s", dtname);
+ appendStringInfo(&buf, "REFRESH DYNAMIC TABLE %s CONCURRENTLY", dtname);
Review Comment:
If there is no unique index, adding the CONCURRENTLY option poses no risk.
It could improve performance if users decide to create a unique index later, so
we should include this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
