This is an automated email from the ASF dual-hosted git repository. reshke pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit d9eed04362109523d46db5adabca28bc01e04967 Author: Brent Doil <[email protected]> AuthorDate: Tue Jan 16 18:34:17 2024 -0500 pg_upgrade: Remove unnecessary line type check The line data type is not implemented in GPDB5 (PG 8.3), no values can be inserted into a line datatype. postgres=# \d foo Table "public.foo" Column | Type | Modifiers --------+---------+----------- a | integer | b | line | Distributed by: (a) postgres=# insert into foo values (1, '{1,4,9}'); ERROR: type "line" not yet implemented LINE 1: insert into foo values (1, '{1,4,9}'); The line type was revived for PG 9.4 in commit 261c7d4. This means the check old_9_3_check_for_line_data_type_usage is not useful because the on-disk representation only changed for GPDB6 (PG 9.4) and is compatible with GPDB7 (PG12). --- src/bin/pg_upgrade/check.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c index 07595c288c..00ff7def74 100644 --- a/src/bin/pg_upgrade/check.c +++ b/src/bin/pg_upgrade/check.c @@ -193,9 +193,12 @@ check_and_dump_old_cluster(bool live_check, char **sequence_script_file_name) old_cluster.controldata.cat_ver < JSONB_FORMAT_CHANGE_CAT_VER) check_for_jsonb_9_4_usage(&old_cluster); + /* GPDB 5 (pg 8.3) has to line data type */ +#if 0 /* Pre-PG 9.4 had a different 'line' data type internal format */ if (GET_MAJOR_VERSION(old_cluster.major_version) <= 903) old_9_3_check_for_line_data_type_usage(&old_cluster); +#endif /* For now, the issue exists only for Greenplum 6.x/PostgreSQL 9.4 */ if (GET_MAJOR_VERSION(old_cluster.major_version) == 904) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
