This is an automated email from the ASF dual-hosted git repository. reshke pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit af87dadf52200241691733ffca9e87126a193f1a Author: Adam Lee <[email protected]> AuthorDate: Mon Mar 18 13:55:58 2024 +0800 Remove a fixme of pg_upgrade makefile installcheck was always a no-op for pg_upgrade until PostgreSQL 15 switched tests to TAP. Remove the fixme. --- src/bin/pg_upgrade/Makefile | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/bin/pg_upgrade/Makefile b/src/bin/pg_upgrade/Makefile index 8df79379e4..41ea1bdf8e 100644 --- a/src/bin/pg_upgrade/Makefile +++ b/src/bin/pg_upgrade/Makefile @@ -57,12 +57,6 @@ clean distclean maintainer-clean: greenplum/aomd_filehandler.c: $(top_srcdir)/src/backend/access/appendonly/aomd_filehandler.c rm -f $@ && cd greenplum && $(LN_S) ../$< aomd_filehandler.c -# GPDB_UPGRADE_FIXME: -# GPDB want to run installcheck of pg_upgrade in the end of installcheck-world -# let installcheck be a no-op, so "make -C src/bin/ installcheck" does nothing on -# src/bin/pg_upgrade, the real test of pg_upgrade will be triggered by -# "make check" in the end of installcheck-world, see GNUmakefile.in - # When $(MAKE) is present, make automatically infers that this is a # recursive make. which is not actually what we want here, as that # e.g. prevents output synchronization from working (as make thinks --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
