This is an automated email from the ASF dual-hosted git repository. reshke pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 37ea55535269957f1871da0f564e1a1896a86303 Author: Kevin Yeap <[email protected]> AuthorDate: Mon Mar 11 18:46:11 2024 -0700 pg_upgrade: check for views using removed types Views that use removed types will cause upgrade to fail. This happens during metadata restore on the target cluster because pg_restore will error trying to create a view using types that do not exist anymore. This is not ideal as we could be many hours into upgrade before a view using a removed type causes pg_upgrade to fail. This check calls a support function on the source cluster to check if views using removed types exist. --- src/bin/pg_upgrade/greenplum/check_gp.c | 106 ++++++++++++++++++++++++++++++-- 1 file changed, 100 insertions(+), 6 deletions(-) diff --git a/src/bin/pg_upgrade/greenplum/check_gp.c b/src/bin/pg_upgrade/greenplum/check_gp.c index afa6e8294a..aae2c3bd70 100644 --- a/src/bin/pg_upgrade/greenplum/check_gp.c +++ b/src/bin/pg_upgrade/greenplum/check_gp.c @@ -29,6 +29,7 @@ static void check_multi_column_list_partition_keys(ClusterInfo *cluster); static void check_for_plpython2_dependent_functions(ClusterInfo *cluster); static void check_views_with_removed_operators(void); static void check_views_with_removed_functions(void); +static void check_views_with_removed_types(void); /* * check_greenplum @@ -51,6 +52,7 @@ check_greenplum(void) check_for_plpython2_dependent_functions(&old_cluster); check_views_with_removed_operators(); check_views_with_removed_functions(); + check_views_with_removed_types(); } /* @@ -856,9 +858,11 @@ check_views_with_removed_operators() PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';")); /* - * Disabling track_counts results in a large performance improvement, - * several orders of magnitude, when walking the views in - * view_has_removed_operators. + * Disabling track_counts results in a large performance improvement of + * several orders of magnitude when walking the views. This is because + * calling try_relation_open to get a handle of the view calls + * pgstat_initstats which has been profiled to be very expensive. For + * our purposes, this is not needed and disabled for performance. */ PQclear(executeQueryOrDie(conn, "SET track_counts TO off;")); @@ -941,9 +945,11 @@ check_views_with_removed_functions() PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';")); /* - * Disabling track_counts results in a large performance improvement, - * several orders of magnitude, when walking the views in - * view_has_removed_operators. + * Disabling track_counts results in a large performance improvement of + * several orders of magnitude when walking the views. This is because + * calling try_relation_open to get a handle of the view calls + * pgstat_initstats which has been profiled to be very expensive. For + * our purposes, this is not needed and disabled for performance. */ PQclear(executeQueryOrDie(conn, "SET track_counts TO off;")); @@ -997,3 +1003,91 @@ check_views_with_removed_functions() else check_ok(); } + +static void +check_views_with_removed_types() +{ + if (GET_MAJOR_VERSION(old_cluster.major_version) > 904) + return; + + char output_path[MAXPGPATH]; + FILE *script = NULL; + bool found = false; + int dbnum; + int i_viewname; + + prep_status("Checking for views with removed types"); + + snprintf(output_path, sizeof(output_path), "views_with_removed_types.txt"); + + for (dbnum = 0; dbnum < old_cluster.dbarr.ndbs; dbnum++) + { + PGresult *res; + int ntups; + int rowno; + DbInfo *active_db = &old_cluster.dbarr.dbs[dbnum]; + PGconn *conn; + bool db_used = false; + + conn = connectToServer(&old_cluster, active_db->db_name); + PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';")); + + /* + * Disabling track_counts results in a large performance improvement of + * several orders of magnitude when walking the views. This is because + * calling try_relation_open to get a handle of the view calls + * pgstat_initstats which has been profiled to be very expensive. For + * our purposes, this is not needed and disabled for performance. + */ + PQclear(executeQueryOrDie(conn, "SET track_counts TO off;")); + + /* Install check support function */ + PQclear(executeQueryOrDie(conn, + "CREATE OR REPLACE FUNCTION " + "view_has_removed_types(OID) " + "RETURNS BOOL " + "AS '$libdir/pg_upgrade_support' " + "LANGUAGE C STRICT;")); + res = executeQueryOrDie(conn, + "SELECT quote_ident(n.nspname) || '.' || quote_ident(c.relname) AS badviewname " + "FROM pg_class c JOIN pg_namespace n on c.relnamespace=n.oid " + "WHERE c.relkind = 'v' " + "AND c.oid >= 16384 " + "AND view_has_removed_types(c.oid) = TRUE;"); + + PQclear(executeQueryOrDie(conn, "DROP FUNCTION view_has_removed_types(OID);")); + PQclear(executeQueryOrDie(conn, "SET search_path to 'pg_catalog';")); + PQclear(executeQueryOrDie(conn, "RESET track_counts;")); + + ntups = PQntuples(res); + i_viewname = PQfnumber(res, "badviewname"); + for (rowno = 0; rowno < ntups; rowno++) + { + found = true; + if (script == NULL && (script = fopen(output_path, "w")) == NULL) + pg_fatal("Could not create necessary file: %s\n", output_path); + if (!db_used) + { + fprintf(script, "Database: %s\n", active_db->db_name); + db_used = true; + } + fprintf(script, " %s\n", PQgetvalue(res, rowno, i_viewname)); + } + + PQclear(res); + PQfinish(conn); + } + + if (found) + { + pg_log(PG_REPORT, "fatal\n"); + gp_fatal_log( + "| Your installation contains views using removed types.\n" + "| These types are no longer present on the target version.\n" + "| These views must be updated to use types supported in the\n" + "| target version or removed before upgrade can continue. A list\n" + "| of the problem views is in the file:\n\t%s\n\n", output_path); + } + else + check_ok(); +} --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
