woblerr commented on code in PR #97:
URL: https://github.com/apache/cloudberry-backup/pull/97#discussion_r3160539123
##########
gpbackman/cmd/constants.go:
##########
@@ -72,4 +73,12 @@ var (
beforeTimestamp string
// Timestamp to delete all backups after.
afterTimestamp string
+
+ // historyDBEnvVars lists, in priority order, the environment variables
+ // inspected when --history-db is not supplied. They are exported by the
+ // standard Cloudberry/Greenplum cluster environment scripts.
+ historyDBEnvVars = []string{
+ "COORDINATOR_DATA_DIRECTORY",
+ "MASTER_DATA_DIRECTORY",
Review Comment:
Supporting a legacy variable doesn't make sense. The cloudberry project
switched to using the `COORDINATOR_DATA_DIRECTORY` starting with version
~`1.5.4`.
I suggest using the current approach right away and not using legacy
compatibility.
Similarly, it is worth removing the mention of `MASTER_DATA_DIRECTORY` in
the rest of the code.
If there are reasons to maintain compatibility with `MASTER_DATA_DIRECTORY`,
let's discuss it.
@MisterRaindrop @tuhaihe What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
