talmacschen-arch commented on code in PR #97:
URL: https://github.com/apache/cloudberry-backup/pull/97#discussion_r3160695012
##########
gpbackman/cmd/constants.go:
##########
@@ -72,4 +73,12 @@ var (
beforeTimestamp string
// Timestamp to delete all backups after.
afterTimestamp string
+
+ // historyDBEnvVars lists, in priority order, the environment variables
+ // inspected when --history-db is not supplied. They are exported by the
+ // standard Cloudberry/Greenplum cluster environment scripts.
+ historyDBEnvVars = []string{
+ "COORDINATOR_DATA_DIRECTORY",
+ "MASTER_DATA_DIRECTORY",
Review Comment:
Thanks for the context — that makes sense given Cloudberry 1.5.4+
standardized on COORDINATOR_DATA_DIRECTORY. The cleanup touches ~9 files
(code + long help strings + README/COMMANDS + tests), so I'd like to hold
off on pushing it as part of this PR until the maintainers have weighed
in on the overall direction. Happy to drop MASTER_DATA_DIRECTORY entirely
in a follow-up commit (or a separate PR) once that's confirmed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
