talmacschen-arch commented on code in PR #97:
URL: https://github.com/apache/cloudberry-backup/pull/97#discussion_r3161115763
##########
gpbackman/cmd/constants.go:
##########
@@ -72,4 +73,12 @@ var (
beforeTimestamp string
// Timestamp to delete all backups after.
afterTimestamp string
+
+ // historyDBEnvVars lists, in priority order, the environment variables
+ // inspected when --history-db is not supplied. They are exported by the
+ // standard Cloudberry/Greenplum cluster environment scripts.
+ historyDBEnvVars = []string{
+ "COORDINATOR_DATA_DIRECTORY",
+ "MASTER_DATA_DIRECTORY",
Review Comment:
Done in 2d886893 — `MASTER_DATA_DIRECTORY` removed from the resolution
chain and from all related help/docs/tests. The `cmd/constants.go`
comment is also updated to drop "Greenplum". Thanks for the consensus!
Addressed in 2d886893 — removing `(or $MASTER_DATA_DIRECTORY)` made
the line naturally shorter.
Done in 2d886893 — `cmd/constants.go:79` now says "Cloudberry" only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
