sureshanaparti commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r569178078
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -207,6 +215,13 @@ protected boolean filter(ExcludeList avoid, StoragePool
pool, DiskProfile dskCh,
return false;
}
+ if (diskProvisioningTypeStrictness){
+ StoragePoolDetailVO hardwareAcceleration =
storagePoolDetailsDao.findDetail(pool.getId(), "hardwareAccelerationSupported");
Review comment:
it is better to define a string constant for
"`hardwareAccelerationSupported`", in some common storage / util class and use
it across.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
