sureshanaparti commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r569179848
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -207,6 +215,13 @@ protected boolean filter(ExcludeList avoid, StoragePool
pool, DiskProfile dskCh,
return false;
}
+ if (diskProvisioningTypeStrictness){
+ StoragePoolDetailVO hardwareAcceleration =
storagePoolDetailsDao.findDetail(pool.getId(), "hardwareAccelerationSupported");
+ if (!dskCh.getProvisioningType().equals("thin") &&
hardwareAcceleration == null ||
!hardwareAcceleration.getValue().equals("true")){
Review comment:
can you move this to a generic method, something like
_supportsDiskProvisioingType_ , and better check for the hypervisor (as this is
only for VMware) and other required checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
