GutoVeronezi commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r582794740



##########
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##########
@@ -156,19 +156,16 @@ public boolean transitionHAState(final HAConfig.Event 
event, final HAConfig haCo
             if (result) {
                 final String message = String.format("Transitioned host HA 
state from:%s to:%s due to event:%s for the host id:%d",
                         currentHAState, nextState, event, 
haConfig.getResourceId());
-                if (LOG.isTraceEnabled()) {
-                    LOG.trace(message);
-                }
+                LOG.debug(message);

Review comment:
       Well, if the real problem is only the cost of building this string, then 
I would ask you to take another look at the preview code, because, in this 
case, the string is already built when it reach the `if` statement, I just took 
off the `if` and changed it to `debug`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to