DaanHoogland commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r580853088
##########
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##########
@@ -156,19 +156,16 @@ public boolean transitionHAState(final HAConfig.Event
event, final HAConfig haCo
if (result) {
final String message = String.format("Transitioned host HA
state from:%s to:%s due to event:%s for the host id:%d",
currentHAState, nextState, event,
haConfig.getResourceId());
- if (LOG.isTraceEnabled()) {
- LOG.trace(message);
- }
+ LOG.debug(message);
Review comment:
@GutoVeronezi you are right they do the check and this is an often
returning discussion; they do the check after parameter evaluation which in
this case is just the passing of the string. This is why I'd like the
evaluation/construction of the String inside the `isEnabled` guarded block as
well. no need to perform an expensive string contruction if you're not going to
use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
