GutoVeronezi commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r582384873
##########
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##########
@@ -156,19 +156,16 @@ public boolean transitionHAState(final HAConfig.Event
event, final HAConfig haCo
if (result) {
final String message = String.format("Transitioned host HA
state from:%s to:%s due to event:%s for the host id:%d",
currentHAState, nextState, event,
haConfig.getResourceId());
- if (LOG.isTraceEnabled()) {
- LOG.trace(message);
- }
+ LOG.debug(message);
Review comment:
@DaanHoogland I understand your concern, however it is not like we are
running `ACS` on an ENIAC; the cost to build a string (with `java.lang`) is
barely notable.
Besides that, it is better to read a code without 'useless' lines.
Furthermore, if we update `log4j` to `log4j 2` it would not be a problem. =)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
