weizhouapache commented on a change in pull request #4323:
URL: https://github.com/apache/cloudstack/pull/4323#discussion_r588127022
##########
File path: systemvm/agent/noVNC/app/ui.js
##########
@@ -1206,38 +1212,14 @@ const UI = {
* ------v------*/
toggleFullscreen() {
- if (document.fullscreenElement || // alternative standard method
- document.mozFullScreenElement || // currently working methods
- document.webkitFullscreenElement ||
- document.msFullscreenElement) {
- if (document.exitFullscreen) {
- document.exitFullscreen();
- } else if (document.mozCancelFullScreen) {
- document.mozCancelFullScreen();
- } else if (document.webkitExitFullscreen) {
- document.webkitExitFullscreen();
- } else if (document.msExitFullscreen) {
- document.msExitFullscreen();
- }
- } else {
- if (document.documentElement.requestFullscreen) {
- document.documentElement.requestFullscreen();
- } else if (document.documentElement.mozRequestFullScreen) {
- document.documentElement.mozRequestFullScreen();
- } else if (document.documentElement.webkitRequestFullscreen) {
-
document.documentElement.webkitRequestFullscreen(Element.ALLOW_KEYBOARD_INPUT);
- } else if (document.body.msRequestFullscreen) {
- document.body.msRequestFullscreen();
- }
- }
- UI.updateFullscreenButton();
+ this.fullScreen = !this.fullScreen
+ UI.rfb.scaleViewport = this.fullScreen
Review comment:
@davidjumani
one of our customers has issue accessing the novnc console, because
scaleViewport is undefined in line 1216
`
UI.rfb.scaleViewport = this.fullScreen
`
But I cannot find this change in novnc repository.
https://github.com/novnc/noVNC/blob/master/app/ui.js#L1209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
