weizhouapache commented on a change in pull request #4323:
URL: https://github.com/apache/cloudstack/pull/4323#discussion_r590398653
##########
File path: systemvm/agent/noVNC/app/ui.js
##########
@@ -1206,38 +1212,14 @@ const UI = {
* ------v------*/
toggleFullscreen() {
- if (document.fullscreenElement || // alternative standard method
- document.mozFullScreenElement || // currently working methods
- document.webkitFullscreenElement ||
- document.msFullscreenElement) {
- if (document.exitFullscreen) {
- document.exitFullscreen();
- } else if (document.mozCancelFullScreen) {
- document.mozCancelFullScreen();
- } else if (document.webkitExitFullscreen) {
- document.webkitExitFullscreen();
- } else if (document.msExitFullscreen) {
- document.msExitFullscreen();
- }
- } else {
- if (document.documentElement.requestFullscreen) {
- document.documentElement.requestFullscreen();
- } else if (document.documentElement.mozRequestFullScreen) {
- document.documentElement.mozRequestFullScreen();
- } else if (document.documentElement.webkitRequestFullscreen) {
-
document.documentElement.webkitRequestFullscreen(Element.ALLOW_KEYBOARD_INPUT);
- } else if (document.body.msRequestFullscreen) {
- document.body.msRequestFullscreen();
- }
- }
- UI.updateFullscreenButton();
+ this.fullScreen = !this.fullScreen
+ UI.rfb.scaleViewport = this.fullScreen
Review comment:
> @weizhouapache That could be a bigger issue since rfb.js is used to
communicate with the host. Did destroying and recreating the console proxy help
? Also could you check whether the customer has tweaked the novnc code in the
cpvm ? Or any issue with the systemvm.iso itself ?
@davidjumani ignore the issue above. It happened when we enlarge the screen
when websocket connection is not working. it is a bug but not critical. we are
still looking for the root cause of the issue. customer uses German keyboard
which is different from us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
