weizhouapache commented on a change in pull request #4323:
URL: https://github.com/apache/cloudstack/pull/4323#discussion_r588926726
##########
File path: systemvm/agent/noVNC/app/ui.js
##########
@@ -1206,38 +1212,14 @@ const UI = {
* ------v------*/
toggleFullscreen() {
- if (document.fullscreenElement || // alternative standard method
- document.mozFullScreenElement || // currently working methods
- document.webkitFullscreenElement ||
- document.msFullscreenElement) {
- if (document.exitFullscreen) {
- document.exitFullscreen();
- } else if (document.mozCancelFullScreen) {
- document.mozCancelFullScreen();
- } else if (document.webkitExitFullscreen) {
- document.webkitExitFullscreen();
- } else if (document.msExitFullscreen) {
- document.msExitFullscreen();
- }
- } else {
- if (document.documentElement.requestFullscreen) {
- document.documentElement.requestFullscreen();
- } else if (document.documentElement.mozRequestFullScreen) {
- document.documentElement.mozRequestFullScreen();
- } else if (document.documentElement.webkitRequestFullscreen) {
-
document.documentElement.webkitRequestFullscreen(Element.ALLOW_KEYBOARD_INPUT);
- } else if (document.body.msRequestFullscreen) {
- document.body.msRequestFullscreen();
- }
- }
- UI.updateFullscreenButton();
+ this.fullScreen = !this.fullScreen
+ UI.rfb.scaleViewport = this.fullScreen
Review comment:
> @weizhouapache I've changed a bit of the novnc UI to allow fullscreen
and pasting into the console.
> fullscreen is defined at line 44 and scaleViewport is defined in rfb.js
@davidjumani
we do not have any problem in our testing. but that customer cannot access
the console. he tried with different browsers.
it is strange. it seem UI.rfb is not initialized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
