[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4666: Fix bug in creating shared network

[GitBox]

weizhouapache commented on a change in pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#discussion_r588201510



##########
File path: ui/src/views/network/CreateSharedNetworkForm.vue
##########
@@ -592,11 +592,12 @@ export default {
           this.formPhysicalNetworkLoading = false
         }
       }).finally(() => {
-        if (isLastNetwork) {
+        if (this.formPhysicalNetworks.length > 0 && 
this.isObjectEmpty(this.formSelectedPhysicalNetwork)) {
           this.form.setFieldsValue({
             physicalnetworkid: 0
           })
-          this.handlePhysicalNetworkChange(this.formPhysicalNetworks[0])
+          const network = (this.formPhysicalNetworks.length > 0) ? 
this.formPhysicalNetworks[0] : physicalNetwork

Review comment:
       @ravening it works without change on line 599-600.
   
   a minor issue is, if I do not input the startip/endip/gw/netmask, I got two 
errors, 1 from UI, 1 from api.
   
![image](https://user-images.githubusercontent.com/57355700/110105173-5d67e600-7da8-11eb-8838-47a350d8ee12.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org