shwstppr commented on a change in pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#discussion_r590158721
##########
File path: ui/src/views/network/CreateSharedNetworkForm.vue
##########
@@ -592,11 +592,12 @@ export default {
this.formPhysicalNetworkLoading = false
}
}).finally(() => {
- if (isLastNetwork) {
+ if (this.formPhysicalNetworks.length > 0 &&
this.isObjectEmpty(this.formSelectedPhysicalNetwork)) {
this.form.setFieldsValue({
physicalnetworkid: 0
})
- this.handlePhysicalNetworkChange(this.formPhysicalNetworks[0])
+ const network = (this.formPhysicalNetworks.length > 0) ?
this.formPhysicalNetworks[0] : physicalNetwork
Review comment:
@ravening Line 599-600 won't be needed with other changes in place.
For two different error messages issue can you please add `return` after
line 738 (original file)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
