shwstppr commented on pull request #4840: URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-805482095
@DaanHoogland > > > > This PR removes the rule(s) validation with api names while importing a role. This will be in sync with the current create role permission behavior. > > > > > > > > > Aren't we fixing the wrong thing here? I'd say add the validation on create role. > > > > > > @DaanHoogland Agree with api validation part. The intent here, is to have the same behavior for rules added through import role and create role permission (where api names are not validated). Otherwise, create role permission can be extended to include the validation for consistency. Also, note that some cmds are added to the API lookup map only when the respective service/plugin is enabled (eg. cloudian connector, kubernetes service, solid fire APIs). > > Ok, @sureshanaparti My preference would be add the checking to the create method, but I won't block for that reason. @DaanHoogland do you approve the changes then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
