DaanHoogland commented on pull request #4840: URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-805907458
Said, I don't block this in favour of timeliness but: <rant> No, I think validation should be done both in this functionality and in the case of createRole. I have the uneasy feeling this is the removal of a feature because it blocks a single user. I do not see how we can justify that. Is there a larger use-case of which this is part that justifies it? and can we solve that in an other way? I think the validation should be more thorough rather than be removed (I.E. make sure a glob resolves to an API before allowing it) </rant> As said, I won't block. I don't have a real world example of a user/use-case to argue we should block this, so merge if you disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
