GutoVeronezi commented on a change in pull request #4875:
URL: https://github.com/apache/cloudstack/pull/4875#discussion_r601773887
##########
File path:
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -1137,11 +1167,11 @@ protected File downloadFromUrlToNfs(String url, NfsTO
nfs, String path, String n
try (FileOutputStream outputStream = new
FileOutputStream(destFile);) {
entity.writeTo(outputStream);
} catch (IOException e) {
- s_logger.debug("downloadFromUrlToNfs:Exception:" +
e.getMessage(), e);
+ s_logger.error("downloadFromUrlToNfs:Exception:" +
e.getMessage(), e);
Review comment:
Suggestion:
We could improve logging here by adding some data, like:
```java
s_logger.error(String.format("Unable to write downloaded data from [%s] to
[%s] due to [%s].", url, destFile, e.getMessage()), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
