GutoVeronezi commented on a change in pull request #4875:
URL: https://github.com/apache/cloudstack/pull/4875#discussion_r601774968
##########
File path:
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -1137,11 +1167,11 @@ protected File downloadFromUrlToNfs(String url, NfsTO
nfs, String path, String n
try (FileOutputStream outputStream = new
FileOutputStream(destFile);) {
entity.writeTo(outputStream);
} catch (IOException e) {
- s_logger.debug("downloadFromUrlToNfs:Exception:" +
e.getMessage(), e);
+ s_logger.error("downloadFromUrlToNfs:Exception:" +
e.getMessage(), e);
}
return new File(destFile.getAbsolutePath());
} catch (IOException e) {
- s_logger.debug("Faild to get url:" + url + ", due to " +
e.toString());
+ s_logger.error("Faild to get url:" + url + ", due to " +
e.toString());
Review comment:
Suggestion:
Pass the exception as parameter to `s_logger.error`:
```java
s_logger.error("Faild to get url:" + url + ", due to " + e.toString(), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
