GutoVeronezi commented on a change in pull request #4875:
URL: https://github.com/apache/cloudstack/pull/4875#discussion_r601775952



##########
File path: 
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -1180,13 +1210,13 @@ protected Answer 
registerTemplateOnSwift(DownloadCommand cmd) {
             try (FileInputStream fs = new FileInputStream(file)) {
                 md5sum = DigestUtils.md5Hex(fs);
             } catch (IOException e) {
-                s_logger.debug("Failed to get md5sum: " + 
file.getAbsoluteFile());
+                s_logger.error("Failed to get md5sum: " + 
file.getAbsoluteFile());

Review comment:
       Suggestion:
   
   Pass the exception as parameter to `s_logger.error`:
   
   ```java
   s_logger.error("Failed to get md5sum: " + file.getAbsoluteFile(), e);
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to