GabrielBrascher edited a comment on pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-837209817


   Here follow my 2cents.
   
   #### 1 - Number of PRs
   
   @rhtyd raised an interesting point regartding the quantity of PRs.
   I agree that there are quite a lot of PRs, and that this can make our life 
harder to track, test, and review them all. However, I understand that many of 
them hold their particular contexts.
   
   I think that creating one issue to track these PRs would help on testing and 
reviewing them all. The idea would be to link any PR that fits this effort on 
enhancing log messages as well as keeping a track of each PR (merged, under 
review, draft, etc).
   
   #### 2 - Creating an log message pattern
   
   I have been running 4.16-SNAPSHOT already with a couple of these toString() 
methods. Personally I am happy to see log messages with a pattern and holding 
solid information. Maybe we can find better formatations than the _JSON like_. 
However, I find them interesting as it is a globally understood pattern for 
anyone at IT.
   
   The biggest plus in adopting `toString` is the standardtization on log 
messages. Nowadays we see all kind of ways of logging resources. Some logs 
present the name, or the ID, sometimes just the UUID, or combinations of them. 
It is about time to promote a standard (which would be possible mostly due to 
`toString`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to