sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639463258
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(),
SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()
&& isHealthCheckFailed != null) {
Review comment:
@ustcweizhou if the results are out of date/incorrect when queried for,
i think better to perform health checks and update the results. (Note: if it is
a sync call, then it can take time, so just notify the operator that results
are out of date and perform fresh health checks before listing routers by
health checks failed). See if any time duration can be set (through API or
global config) to validate the results are outside of that duration or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
