weizhouapache commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639132477
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(),
SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()
&& isHealthCheckFailed != null) {
Review comment:
@sureshanaparti if "router.health.checks.enabled" was "true" and then
changed to "false", the health check results will be out of date and incorrect.
In this case, do we need to consider the health check results ?
> @ustcweizhou what if "_router.health.checks.enabled_" config is disabled
and there are last health check reports ? Will the routers listed with
healthchecksfailed=true returns empty list or routers with last failed reports
or notifies health checks are not enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
