sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639685281
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(),
SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()
&& isHealthCheckFailed != null) {
Review comment:
> @sureshanaparti
> I think we need to make sure that the health check results are correct.
> if "router.health.checks.enabled" is changed from "true" to "false", we'd
better remove all existing health check results as they will not be updated any
more. btw: can we perform health check via api or ui when
router.health.checks.enabled" is 'false" ?
@weizhouapache i think, the existing health check results are still there
after changing "router.health.checks.enabled" from "true" to "false". May be
this change can be checked in existing background thread and can cleanup the
old health check results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
