DaanHoogland commented on a change in pull request #5045:
URL: https://github.com/apache/cloudstack/pull/5045#discussion_r641374830
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4048,7 +4048,10 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
vm.setDetail(VmDetailConstants.FIRMWARE, "efi");
s_logger.info("guestOS is OSX : overwrite root disk
controller to scsi, use smc and efi");
} else {
- String controllerSetting =
_configDao.getValue("vmware.root.disk.controller");
+ String controllerSetting =
_configDao.getValue(Config.VmwareRootDiskControllerType.key());
+ if (StringUtils.isEmpty(controllerSetting)) {
+ controllerSetting =
Config.VmwareRootDiskControllerType.getDefaultValue();
+ }
Review comment:
converting this setting to modern ConfigKey<> would be more failsafe and
concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
