sureshanaparti commented on a change in pull request #5076:
URL: https://github.com/apache/cloudstack/pull/5076#discussion_r647318656
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/ScsiDiskControllerType.java
##########
@@ -17,8 +17,10 @@
package com.cloud.hypervisor.vmware.mo;
public interface ScsiDiskControllerType {
- public final static String LSILOGIC_PARALLEL = "lsilogic";
- public final static String LSILOGIC_SAS = "lsisas1068";
- public final static String BUSLOGIC = "buslogic";
- public final static String VMWARE_PARAVIRTUAL = "pvscsi";
+ String LSILOGIC_PARALLEL = "lsilogic";
+ String LSILOGIC_SAS = "lsilogicsas";
+ String LSILOGIC_SAS_1068 = "lsisas1068";
Review comment:
@nvazquez Any strings there are internal to CloudStack? Check the SCSI
controller types here:
-
https://vmware.github.io/vsphere-automation-sdk-python/vsphere/cloud/com.vmware.vcenter.vm.hardware.html
-
https://vmware.github.io/vsphere-automation-sdk-java/vsphere/6.5.0/vsphereautomation-client-sdk/com/vmware/vcenter/vm/hardware/adapter/ScsiTypes.Type.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
