andrijapanicsb commented on a change in pull request #5076:
URL: https://github.com/apache/cloudstack/pull/5076#discussion_r647352164
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/ScsiDiskControllerType.java
##########
@@ -17,8 +17,10 @@
package com.cloud.hypervisor.vmware.mo;
public interface ScsiDiskControllerType {
- public final static String LSILOGIC_PARALLEL = "lsilogic";
- public final static String LSILOGIC_SAS = "lsisas1068";
- public final static String BUSLOGIC = "buslogic";
- public final static String VMWARE_PARAVIRTUAL = "pvscsi";
+ String LSILOGIC_PARALLEL = "lsilogic";
+ String LSILOGIC_SAS = "lsilogicsas";
+ String LSILOGIC_SAS_1068 = "lsisas1068";
Review comment:
@sureshanaparti I've reviewed the links, and I don't find this to be
true in reality - please see this "table bellow" - without ACS, I've created a
VM in vSpher 6.7, inspected the controller type in VMX, then exported to OVA,
which sometimes had different controller type - please see. I also imported
e.g. OVA with "lsilogicsas" and it became "lsisas1068" inside VMX:
vCenter UI VMX
OVF
BusLogic Parallel NA (not specified!)
buslogic
LSI Logic Parallel lsilogic
lsilogic
LSI Logic SAS lsisas1068
lsilogicsas
VMware Paravirtual pvscsi
VirtualSCSI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
