PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-907087891
to reiterate; - I'm -0 on this. - This adds some amount of risk with no real stated justification as far as I can see - There are over 40 parameters to the createserviceoffering API. Basic offerings are there out of the box so, the domain admin **will** be using a chunk of them to define a 'non-basic' offering, removing the need to specify **one** parameter will make a negligible difference to the effort involved. Yes, a global setting defaulting to current behaviour would add back the failsafe that is currently in place. Yes, that does seem like massive overkill, but so is the PR IMO so 🤷🏻♂️. While this issue has taken center stage, there is still an outstanding question/comment from Gabriel, RE null domainids creating public offerings, which needs to be addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
