sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r699022488
##########
File path:
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -1448,10 +1452,15 @@ public int compare(Volume v1, Volume v2) {
else
requestVolumes = new ArrayList<Volume>();
requestVolumes.add(vol);
-
+ List<Pair<Volume, DiskProfile>>
volumeDiskProfilePair = new ArrayList<>();
+ for (Volume volume: requestVolumes) {
+ DiskOfferingVO diskOffering =
_diskOfferingDao.findById(volume.getDiskOfferingId());
+ DiskProfile diskProfile = new
DiskProfile(volume, diskOffering, _volsDao.getHypervisorType(volume.getId()));
+ volumeDiskProfilePair.add(new
Pair<>(volume, diskProfile));
Review comment:
possible to move creation of volume disk profile pair (from the
volumes), to a common method and use it across?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
