sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r699027764
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -2317,13 +2322,13 @@ public boolean storagePoolHasEnoughIops(List<Volume>
requestedVolumes, StoragePo
}
@Override
- public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool
pool) {
- return storagePoolHasEnoughSpace(volumes, pool, null);
+ public boolean storagePoolHasEnoughSpace(List<Pair<Volume, DiskProfile>>
volumeDiskProfilePairs, StoragePool pool) {
+ return storagePoolHasEnoughSpace(volumeDiskProfilePairs, pool, null);
}
@Override
- public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool
pool, Long clusterId) {
- if (volumes == null || volumes.isEmpty()) {
+ public boolean storagePoolHasEnoughSpace(List<Pair<Volume, DiskProfile>>
volumeDiskProfilesList, StoragePool pool, Long clusterId) {
+ if (volumeDiskProfilesList == null ||
volumeDiskProfilesList.isEmpty()) {
Review comment:
```suggestion
if (CollectionUtils.isEmpty(volumeDiskProfilesList)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
