weizhouapache commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r718308595
##########
File path:
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -1558,7 +1558,8 @@ protected boolean hostCanAccessSPool(Host host,
StoragePool pool) {
DiskOfferingVO diskOffering =
_diskOfferingDao.findById(toBeCreated.getDiskOfferingId());
- if (vmProfile.getTemplate().getFormat() == Storage.ImageFormat.ISO
&& vmProfile.getServiceOffering().getTagsArray().length != 0) {
+ if ((vmProfile.getTemplate().getFormat() ==
Storage.ImageFormat.ISO || toBeCreated.getVolumeType() == Volume.Type.ROOT)
+ && vmProfile.getServiceOffering().getTagsArray().length !=
0) {
Review comment:
@sureshanaparti
as I said in the description
```
In some cases, the disk offering of ROOT disk is not same as service
offering of VM.
for example
(1) create a vm but not start it, then scale vm to another service offering
(2) reinstall vm, then scale vm to another service offering
These two issues are fixed by this PR.
The issue might exist in some other scenarios, so it would be better to
always update ROOT disk offering tags to the tags of vm service offering in
DeploymentPlanningManagerImpl.java.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
