sureshanaparti commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r718283317
##########
File path:
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -1558,7 +1558,8 @@ protected boolean hostCanAccessSPool(Host host,
StoragePool pool) {
DiskOfferingVO diskOffering =
_diskOfferingDao.findById(toBeCreated.getDiskOfferingId());
- if (vmProfile.getTemplate().getFormat() == Storage.ImageFormat.ISO
&& vmProfile.getServiceOffering().getTagsArray().length != 0) {
+ if ((vmProfile.getTemplate().getFormat() ==
Storage.ImageFormat.ISO || toBeCreated.getVolumeType() == Volume.Type.ROOT)
+ && vmProfile.getServiceOffering().getTagsArray().length !=
0) {
Review comment:
@weizhouapache first scenario - when VM is deployed from ISO, what is
the other scenario ?
Does attach data disk as root disk supported?
##########
File path: engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java
##########
@@ -365,6 +375,12 @@ public VolumeDaoImpl() {
AllFieldsSearch.and("name", AllFieldsSearch.entity().getName(), Op.EQ);
AllFieldsSearch.done();
+ RootDiskStateSearch = createSearchBuilder();
Review comment:
May be you can re-use _AllFieldsSearch_, by changing Op.EQ to Op.IN
here:
https://github.com/apache/cloudstack/blob/67bc74de56357eeefdec9cccb6314d73dc757f5d/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java#L362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
