DaanHoogland commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r717364990
##########
File path: engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java
##########
@@ -217,6 +218,15 @@ public VolumeVO findByPoolIdName(long poolId, String name)
{
return listBy(sc);
}
+ @Override
+ public List<VolumeVO> findReadyAndAllocatedRootVolumesByInstance(long
instanceId) {
Review comment:
nitpick: `findReadyAndAllocatedRootVolumeByInstance` (singular) we are
only looking for one volume, can we encounter more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
