nvazquez commented on a change in pull request #5565:
URL: https://github.com/apache/cloudstack/pull/5565#discussion_r726072928
##########
File path:
engine/schema/src/main/resources/META-INF/db/schema-41520to41600-cleanup.sql
##########
@@ -19,4 +19,4 @@
-- Schema upgrade cleanup from 4.15.2.0 to 4.16.0.0
--;
-ALTER TABLE `cloud`.`ssh_keypairs` MODIFY COLUMN `uuid` varchar(40) NOT NULL
UNIQUE;
\ No newline at end of file
+ALTER TABLE `cloud`.`ssh_keypairs` ADD CONSTRAINT `uc_ssh_keypairs__uuid`
UNIQUE (`uuid`);
Review comment:
It is added in the cleanup file as the UUID generation for sshkeypairs
is handled in the java code por the upgrade path. See:
https://github.com/apache/cloudstack/pull/5103/commits/7c7925edb12ab670dbe5e018d0ada36c616bd0a7#diff-06996fafc77d65da40b9caead01b27f56da70143795cd7b261840ada0727883bR70.
It is done like this to avoid a point @davidjumani mentioned above, to avoid
the case in which all the keypairs will get the same UUID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
