weizhouapache commented on a change in pull request #5565:
URL: https://github.com/apache/cloudstack/pull/5565#discussion_r726085294
##########
File path:
engine/schema/src/main/resources/META-INF/db/schema-41520to41600-cleanup.sql
##########
@@ -19,4 +19,4 @@
-- Schema upgrade cleanup from 4.15.2.0 to 4.16.0.0
--;
-ALTER TABLE `cloud`.`ssh_keypairs` MODIFY COLUMN `uuid` varchar(40) NOT NULL
UNIQUE;
Review comment:
@nvazquez
I did a small testing, see below
```
mysql> update ssh_keypairs set uuid=NULL ;UPDATE `cloud`.`ssh_keypairs` SET
`uuid`=UUID() WHERE `uuid` IS NULL;select uuid from ssh_keypairs;
Query OK, 4 rows affected (0.01 sec)
Rows matched: 4 Changed: 4 Warnings: 0
Query OK, 4 rows affected (0.00 sec)
Rows matched: 4 Changed: 4 Warnings: 0
+--------------------------------------+
| uuid |
+--------------------------------------+
| f09d204e-2a90-11ec-8103-1e0079000360 |
| f09d26e8-2a90-11ec-8103-1e0079000360 |
| f09d290e-2a90-11ec-8103-1e0079000360 |
| f09d2a97-2a90-11ec-8103-1e0079000360 |
+--------------------------------------+
4 rows in set (0.00 sec)
mysql> update ssh_keypairs set uuid=NULL ;UPDATE `cloud`.`ssh_keypairs` SET
`uuid`=UUID() WHERE `uuid` IS NULL;select uuid from ssh_keypairs;
Query OK, 4 rows affected (0.00 sec)
Rows matched: 4 Changed: 4 Warnings: 0
Query OK, 4 rows affected (0.01 sec)
Rows matched: 4 Changed: 4 Warnings: 0
+--------------------------------------+
| uuid |
+--------------------------------------+
| f2af974d-2a90-11ec-8103-1e0079000360 |
| f2af9d0a-2a90-11ec-8103-1e0079000360 |
| f2af9f0c-2a90-11ec-8103-1e0079000360 |
| f2afa083-2a90-11ec-8103-1e0079000360 |
+--------------------------------------+
4 rows in set (0.00 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]