ravening commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r754116626
##########
File path:
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account,
final ResourceType type, l
}
final Project projectFinal = project;
+
+ // Check account limits. If it's unlimited then don't lock the db rows
+ long accountResourceLimit =
findCorrectResourceLimitForAccount(account, type);
+ if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {
Review comment:
@DaanHoogland if thats the case then whats the use of using `-1` as
value for resource limit? Also whats the use of having the check like
`accountResourceLimit == -1 then skip something` ?
Having -1 on account resource limit and limiting it on the domain level,
defeats the whole purpose of `-1` right?
If that is the case then -1 shouldnt be allowed at all on account level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
