ravening commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r753218799



##########
File path: 
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account, 
final ResourceType type, l
         }
 
         final Project projectFinal = project;
+
+        // Check account limits. If it's unlimited then don't lock the db rows
+        long accountResourceLimit = 
findCorrectResourceLimitForAccount(account, type);
+        if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {

Review comment:
       @weizhouapache but whats the point in updating the account resource when 
account limit is -1? as you said above, -1 means unlimited resources. then 
updating the domain resource limit doesnt make any sense.
   
   if we update the domain resource count then -1 no longer has its meaning




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to