weizhouapache commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r753379488
##########
File path:
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account,
final ResourceType type, l
}
final Project projectFinal = project;
+
+ // Check account limits. If it's unlimited then don't lock the db rows
+ long accountResourceLimit =
findCorrectResourceLimitForAccount(account, type);
+ if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {
Review comment:
> @weizhouapache yes there are two isolation levels but can you answer
the below question?
>
> Domain has three account A, B and C Domain resource limit is 100
>
> A : resource limit is -1 and current resource count is 200 B: resource
limit is 50 and current resource count is 30 C : resource limit is 50 and
current resource count is 40
>
> So you are saying that the total domain count should be 270 (200 + 40 +
30) and not 70 (30 + 40) ?
@ravening yes, the total resource count of domain is 270.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
