weizhouapache commented on a change in pull request #5721:
URL: https://github.com/apache/cloudstack/pull/5721#discussion_r757502180
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -3808,7 +3808,7 @@ public boolean upgradeVmDb(final long vmId, final
ServiceOffering newServiceOffe
if (currentServiceOffering.isDynamic() &&
!newServiceOffering.isDynamic()) {
removeCustomOfferingDetails(vmId);
}
- VMTemplateVO template =
_templateDao.findById(vmForUpdate.getTemplateId());
+ VMTemplateVO template =
_templateDao.findByIdIncludingRemoved(vmForUpdate.getTemplateId());
Review comment:
@sureshanaparti
I think it should be ok. If template is configured to support dynamic
scaling, the VM image should support it as well because the vm image is created
from the template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
