sureshanaparti commented on a change in pull request #5721:
URL: https://github.com/apache/cloudstack/pull/5721#discussion_r758084256
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -3808,7 +3808,7 @@ public boolean upgradeVmDb(final long vmId, final
ServiceOffering newServiceOffe
if (currentServiceOffering.isDynamic() &&
!newServiceOffering.isDynamic()) {
removeCustomOfferingDetails(vmId);
}
- VMTemplateVO template =
_templateDao.findById(vmForUpdate.getTemplateId());
+ VMTemplateVO template =
_templateDao.findByIdIncludingRemoved(vmForUpdate.getTemplateId());
Review comment:
@weizhouapache @harikrishna-patnala If VM existence (and it's scaling)
is allowed after template deletion, better to skip dynamically scalable flag in
that template (and consider as 'true'). If one wants to scale the VM when the
flag is false, it is not possible to update the flag on the deleted template
(this blocks to retry the scaling operation when all the relevant flags are
enabled). What's your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
