sureshanaparti commented on a change in pull request #5730:
URL: https://github.com/apache/cloudstack/pull/5730#discussion_r759125691
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java
##########
@@ -249,11 +259,31 @@ public Long getPhysicalNetworkId() {
throw new InvalidParameterValueException("Unable to find network
offering by ID " + networkOfferingId);
}
+ Network associatedNetwork = null;
+ if (associatedNetworkId != null) {
+ associatedNetwork = _entityMgr.findById(Network.class,
associatedNetworkId);
+ if (associatedNetwork == null) {
+ throw new InvalidParameterValueException("Unable to find
network by ID " + associatedNetworkId);
Review comment:
I think, this is already checked in the API call when UUID is
transformed to the DB 'ID'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
